search

prio-data / viewser

A CLI for interacting with the ViEWS 3 backend
Other
4 stars 0 forks source link

Better queryset errors #38

Open hhegre opened 2 years ago

hhegre commented 2 years ago

Would be good if more queryset error messages reach the user. For instance, in :

.with_column(Column("ged_gte_25","country_month","ged_sb_best_sum_nokgx")

it would be very useful if this results in error messages telling us that "country_month" is not a table in the database and (if the table exists) that "ged_sb_best_sum_nokgx" is not a column in this table.

I understand some error message is produced in the logs, but it would be more convenient if they are visible from the notebook.

Peder2911 commented 2 years ago

Hey! This is a really important issue that I have been working towards here: https://github.com/prio-data/viewser/issues/33

The underlying error handling code for providing better feedback has actually been written already, I just need to document the process and make the backend return useful error messages when appropriate. Thanks for raising this!

Peder2911 commented 2 years ago

Handling a lot of the underlying problems here: https://github.com/prio-data/views_queryset_manager/pull/17

Peder2911 commented 2 years ago

Remedied by ^, although errors could still probably be made a lot better.