prior-art-archive / priorartarchive.org

Prior Art Archive Site
https://priorartarchive.org
GNU General Public License v2.0
3 stars 1 forks source link

Add blacklist of organizations that will not show up in normal search results #28

Open metasj opened 5 years ago

metasj commented 5 years ago

We have some test organizations that should not appear in search results. We also let anyone register and upload files, some of which we may want to hide.

While we also want a way to delete files, a simple start is to have a reversible way to hide all files from one org while evaluating it.

There should still be a way to see those orgs and their docs for review -- and to modify the blacklist.

reefdog commented 5 years ago

Are there other (perhaps weird/inorganic) ways of getting to documents or orgs — say, incrementing IDs in URLs — where these orgs/docs should also be hidden? In other words, should these things remain public, just excluded from search results, or should they be fully hidden from public view until noted otherwise?

Just spitballing, but it seems we kinda need three organization statuses/flags: testing (hidden from everyone but internal users), pending (hidden from public views until evaluated/approved by an admin), and public/approved/whatever. Does that seem right? (And of course, the org status/flag is inherited by its documents.)

joeltg commented 5 years ago

I think the way to do this is to first implement #17, and then either restrict signups to approved emails, or add some verified property to orgs that determines their ability to upload documents.

Blacklist + open signups is backward / if we don't want just anyone uploading stuff, we shouldn't wait for them to do it to block them.

metasj commented 5 years ago

I reckon we do want open signups and upload; but the default view and search should not show all results. (Like not showing 'bot edits' by default in many tools' feed of changes). We can have an autoverification process that verifies people based on their behavior, which can be overridden (up or down) by hand-verificatoin for anyone we preemptively approve. Right now the orgs we want to blacklist are our own test orgs.

metasj commented 5 years ago

It's fine to drop the general feature from v2, but files from test orgs should be hidden or deleted as part of shifting to a real dev/prod separation