prior-art-archive / priorartarchive.org

Prior Art Archive Site
https://priorartarchive.org
GNU General Public License v2.0
3 stars 1 forks source link

Add ability to edit document titles #6

Closed reefdog closed 5 years ago

reefdog commented 5 years ago

With this PR, users gain the ability to edit titles and descriptions through the document detail page. Titles are required, while descriptions are optional (and can be deleted). Users can close the form without saving; there's currently no warning or confirmation when closing without saving, but that seems okay since we're talking a small amount of info.

While reviewing, pay particular attention to the new API call for editing the document. I believe it checks the user's permissions properly and only allows changing the title and description, but this is obviously a sensitive action so please double-check me!

recording

Closes #18

metasj commented 5 years ago

Title editing should allow editing by an admin, in a way that captures who made the last edit. (Uploaders are often not available to clean up their files)

slifty commented 5 years ago

@metasj this PR is in response to issue #18 which explicitly is requesting the ability for uploaders to edit their titles.

What you are describing sounds like a second issue; could you create that, and reference #18.

metasj commented 5 years ago

18 includes "We will also want to be able to bulk update some titles with scripts, for instance those with blank titles and HTML pages with long, unhelpful ones." So no new issue needed I think, but perhaps an additional PR ~

slifty commented 5 years ago

Got it.

Either way it would be appropriate to break that into its own issue since it sounds like #18 was actually a compound issue (had I realized I would have suggested splitting anyway!)