prioritizr / wdpar

Interface to the World Database on Protected Areas
https://prioritizr.github.io/wdpar
GNU General Public License v3.0
37 stars 5 forks source link

address reviewer comments by @drmattg #64

Closed jeffreyhanson closed 1 year ago

jeffreyhanson commented 1 year ago

This PR aims to address the issues raised by @DrMattG. Specifically, it adds links for citations in the README (#58) and adds more information about the versining to wdpa_fetch() (#59). When you get a chance @DrMattG, could you please take a look and let me know if this PR satifies your concerns?

codecov[bot] commented 1 year ago

Codecov Report

Merging #64 (bb04582) into master (d075533) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          10       10           
  Lines         517      517           
=======================================
  Hits          504      504           
  Misses         13       13           
Impacted Files Coverage Δ
R/wdpa_fetch.R 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jeffreyhanson commented 1 year ago

Awesome - thanks for approving the PR @DrMattG, I'll merge it now.