prisma-archive / graphcool-templates

📗 Collection of Graphcool Templates
MIT License
361 stars 100 forks source link

Smaller auth0 package #129

Open prestontighe opened 7 years ago

prestontighe commented 7 years ago
timwis commented 7 years ago

I was under the impression isomorphic-fetch just attached itself to the window or global object, so that the fetch that's used later is defined.

kbrandwijk commented 7 years ago

@timwis You are right, it is used indeed. It could have been node-fetch however, because it doesn't run in the browser anyways. I would also use import fetch from 'node-fetch' so it's clear that it is actually being used.

prestontighe commented 7 years ago

Ah ok didn't know what it did. Creating a global variable from requiring a package seems like bad practice to me but o well. At least do import fetch from 'node-fetch' like you said @kbrandwijk .