search

prisma-archive / prep

Pre-renders your web app (React, Vue, Angular, ...) into static HTML based on your specified routes enabling SEO for single page applications.
MIT License
373 stars 27 forks source link

Netlify build failing #9

Closed mvanlonden closed 7 years ago

mvanlonden commented 7 years ago

https://github.com/graphcool/prep/blob/master/src/index.js#L1 Specifies where to source node, but in Netlify's build image node lives somewhere else. This is causing builds to fail. When I run prep in the build container locally... buildbot@537748d807a3:~/repo$ ./node_modules/.bin/prep -c ./src/prerender/prep.js build I get an error /usr/bin/env: node: No such file or directory

mvanlonden commented 7 years ago

PS this is the first prerendering library that has really worked for me :) cc @marktani

schickling commented 7 years ago

Hmm that's a good catch. @bdougie would you mind helping @mvanlonden out how to debug this on Netlify?

fool commented 7 years ago

Hey Johannes! I don't think there's anything to debug on our side yet. I worked through this with Michael in support already - I think it probably works fine if he follows my advice around how to run commands in the container (hint: you HAVE to use the build shell command in front of your build command).

So, we'll be waiting to see him try that here before debugging at all

mvanlonden commented 7 years ago

Sorry for the miscommunication, misunderstood @fool via email. Got past that issue but now nightmare is getting hung up. screenshot

Probably has something to do with the Netlify Dockerfile because I don't see the same config there as in the Dockerfile on this repo. relevant comment

mvanlonden commented 7 years ago

Since my pages are fairly dynamic I've decided to go with a middleware solution instead of a build chain one. prerender.cloud seems to do the trick