search

prisma-labs / dripip

Opinionated CLI for continuous delivery of npm packages
100 stars 2 forks source link

PR builds aren't identifiable for backdated releases #127

Open OmgImAlexis opened 2 years ago

OmgImAlexis commented 2 years ago

Perceived Problem

So ultimately 0.0.0 is the most sensible general choice.

0.0.0 doesn't align with any of our other tools. This makes it harder to workout what the base version was that the PR is based on. A PR that's based on v1.6.0 and is going to be backdated wouldn't be the same as one based on v2.5 and is going to be merged into the main as a new version.

Ideas / Proposed Solution(s)

Allow PR builds to base their version off of the current package.json. This way PRs would be ${baseVersion}-pr.${pr_num}.${pr_release_num}.${short_sha} resulting in easily identifiable builds.

OmgImAlexis commented 2 years ago

Users also can't update to PR builds easily as it's not seen as a step up via semver. 0.0.0 is seen as an earlier version.