prisma-labs / dripip

Opinionated CLI for continuous delivery of npm packages
100 stars 2 forks source link

dripip github action #57

Open jasonkuhrt opened 4 years ago

jasonkuhrt commented 4 years ago

https://help.github.com/en/actions/building-actions/creating-a-javascript-action

Instead of this:

      - name: Make release
        id: release
        env:
          NPM_TOKEN: ${{secrets.NPM_TOKEN}}
        run: |
          yarn -s dripip preview --json > result.json
          result=$(cat result.json)
          echo '==> Publish Result'
          jq '.' <<< $result
      - name: Save publish result
        uses: actions/upload-artifact@v1
        with:
          name: published
          path: result.json

This

- uses: prisma-labs/dripip
  with:
    npm_token: ${{ secrets.NPM_TOKEN }}    

For handling the artifacts part, refer to this issue which mentions more https://github.com/actions/upload-artifact/issues/62.

jasonkuhrt commented 4 years ago

In lieu of #58 we might be able to workaround using forks. If we really want to avoid the sdk work for now.

jasonkuhrt commented 4 years ago
  1. New requirement discovered for this issue from https://github.com/prisma-labs/dripip/issues/71. CI now needs GITHUB_TOKEN.

  2. Another thing we need to cover, hit this today (don't know why I didn't hit it before...) https://github.com/actions/checkout/issues/217; specifically the part about needing to pull in all git tags (depth: 0 I knew about from before).

jasonkuhrt commented 4 years ago

Note the solution for pulling git tags has some discussion here https://github.com/actions/checkout/issues/206 / https://github.com/actions/checkout/issues/206#issuecomment-617937725