prisma-labs / graphql-framework-experiment

Code-First Type-Safe GraphQL Framework
https://nexusjs.org
MIT License
675 stars 66 forks source link

Integrate logs from debug module into logger #265

Open jasonkuhrt opened 4 years ago

jasonkuhrt commented 4 years ago

What

Why

How

jasonkuhrt commented 4 years ago

Open questions:

  1. Would santa still use debug

    Could, maybe not to keeping our codebase simpler

  2. How would we handle/react to the DEBUG environment variable

    LOG_LEVEL=trace --> DEBUG=*
    

    But what about this?

    DEBUG=* --> LOG_LEVEL=trace | +Warning? | Error? | ...
    • We could support it, but not advertise it
    • We could do a passthrough where if this env var is found, we do a raw passthrough to debug and let debug do its native behaviour
    • Consider this an escape hatch, especially until #264 since DEBUG offers filtering solution that we might not have ourselves for unknown amount of time.