search

prisma / language-tools

🌐 Prisma Language Tools = Language Server and Prisma's VS Code extension.
https://marketplace.visualstudio.com/items?itemName=Prisma.prisma
Apache License 2.0
257 stars 40 forks source link

Formatting the schema.prisma file makes VSCode scroll down #1590

Open divmgl opened 1 year ago

divmgl commented 1 year ago

Bug description

Formatting the schema.prisma file scrolls the entire window down.

How to reproduce

  1. Create a schema.prisma file that is larger than a screen's height.
  2. Format the document.
  3. Observe the screen getting scrolled down.

Expected behavior

The document is formatted without scrolling.

Prisma information

Prisma version 5.4.2

Environment & setup

janpio commented 1 year ago

I can not reproduce this, for me it formats the document and just visually updates the current "view" of the schema file I have, whereever I am scrolled to.

How do you format the document? Is your VS Code configured somehow different than normal?

divmgl commented 10 months ago

Sorry, I'm still running into this. VSCode is configured with format on save. I'm just using the Prisma extension. We have a really long schema file. We do have

"editor.codeActionsOnSave": {
  "source.fixAll": "explicit"
},

turned on, so maybe that's needed to make this happen? It is extremely annoying but it's not a blocker at all.

I haven't had to time to create a reproduction case but I hope this helps.

divmgl commented 10 months ago

Oh, and it only scrolls down when it needs to format the document on save. Like, if I make a change and press Cmd+S it scrolls down.

mriosb commented 9 months ago

I have the exact same issue. My schema file is 2800 lines long. When I format on save, it jumps down 100 lines.

janpio commented 9 months ago

So not the "entire window down" as described in the title, but just 100 lines @mriosb?

divmgl commented 4 months ago

Hey guys, this is happening consistently. Sometimes it will scroll down a little, sometimes it scroll downs an entire page.

Our schema file is 2900 lines. It only scrolls down when there's a change that requires formatting.