search

prisma / language-tools

🌐 Prisma Language Tools = Language Server and Prisma's VS Code extension.
https://marketplace.visualstudio.com/items?itemName=Prisma.prisma
Apache License 2.0
251 stars 34 forks source link

LSP Rename incorrectly maps field name and appends character #1771

Closed kevintraver closed 2 weeks ago

kevintraver commented 1 month ago

Bug description

LSP Rename incorrectly maps field name and appends character

How to reproduce

use LSP Rename code action to rename dateAdded to addedDate

dateAdded          DateTime? @db.DateTime

Result

addedDate          DateTime? @db.DateTim @map("dateAdded")e

Expected behavior

addedDate          DateTime? @db.DateTime @map("dateAdded")

Prisma information

Version: 15.5.0

Environment & setup

kevintraver commented 1 month ago

I think it might have something to do with this change: fe081ac

Druue commented 3 weeks ago

Hey @kevintraver, I can indeed confirm this :/ Looks like that change is the culprit indeed

https://github.com/prisma/language-tools/assets/29753584/7c3c1761-a0e8-4831-a9ad-0224a6555541

Druue commented 2 weeks ago

This fix will be part of the 5.17.0 release and is already on our latest version of Insiders. (Though I see you use nvim so not sure how long that takes to propagate there)

https://github.com/user-attachments/assets/93e9753e-09a7-4651-94a1-927eb9b5539c

kevintraver commented 2 weeks ago

It appears fixed! 🎉