Fail validating when using not English column

[sacru2red]

Bug description

extension shows

Error validating: This line is not a valid field or attribute definition.Prisma

How to reproduce

add columns not english charaters

Expected behavior

prisma pass validating

Prisma information

Environment & setup

• OS: Windows 11
• Editor: Vscode
• Editor version: 1.91.1
• Extension version: v5.17.0

[Druue]

Can confirm this

model A {
  lööps String
}

This is due to how we parse field identifiers in PEST:

identifier = @{ ASCII_ALPHANUMERIC ~ ( "_" | "-" | ASCII_ALPHANUMERIC)* }

So the character that you highlight is non-ascii and therefore doesn't get picked up, we need to update the identifier to be inclusive of unicode characters :) The docs are here: https://pest.rs/book/grammars/built-ins.html

[sacru2red]

cool! Thank you for quick response.

[Druue]

Note: having discussed this internally, we're going to move forward with adding a validation warning specifically for using non-ASCII characters which includes a recommendation to use the @map attribute if wanting to use unicode characters, as the current validation for it is generic and unhelpful.

Fully supporting bare unicode characters would be a wider-spread feature request which would affect the client as well. If you could please open a feature request in prisma/prisma where you outline your use case for direct usage of unicode characters instead of through @map, that would be appreciated 🙏

[sacru2red]

hello. I'm not a native English speaker, and the translator doesn't work properly, so I didn't understand exactly what it meant.

• Support for non-ASCII characters is not in progress.
• However, the current message is unhelpful and will be fixed.
• Nevertheless, if you want to work on it, please leave an issue with a use case in the prisma/prisma repo, not this repo.

Is this what you mean?

[Druue]

Yes! @sacru2red