prisma / prisma-1-cloud-feedback

Feedback for Prisma Cloud
https://app.prisma.io
5 stars 4 forks source link

Prisma Service Domains contain `_` and are therefore not RFC1034 compliant #223

Open zetaron opened 5 years ago

zetaron commented 5 years ago

The service domain used by prisma to host both the graphql-playground and graphql-api is not complaint with the RFC1034 spec for CNAME labels.

server-name_organization.prisma.sh. 128 IN CNAME random-aws-resource.eu-west-1.elb.amazonaws.com.

The left side is called label and the right side CNAME, therefore the label would be server-name_organization.prisma.sh. and the CNAME consequently random-aws-resource.eu-west-1.elb.amazonaws.com.. Most implementations of the RFC don't seem to have a problem with the, by spec, illegal _ character but some implement it very strictly, one of these more strict one is the erlang idna package.

For you to be able to test this issue and hopefully find a solution I've setup a small test project over at zetaron/elixir-prisma-graphql-idna-issue, please follow the README on how to use it.