Types & Queries not updated after deploy

ianjanicki commented 5 years ago

Previously, the data-viewer editor would auto-update the 'queries' in the left-hand panel. I've noticed two bugs regarding updating the data model and deploying to the demo servers:

Queries are not automatically removed: Previously, post-deploy, if a type was removed from the model, the 'query' in the data viewer would be automatically removed. This was very convenient for those constantly updating our data models. Not you have to manually delete it.
Queries not updated if field type changed: I just changed a field in my datamodel from a relation to a Json; and the query kept throwing an error due to it looking for the previous relation id (since there is no sub-selection to a Json). I fixed it, but it was a bit confusing, and wish, again, these things would be automatically updated.

huv1k commented 5 years ago

So prisma-admin was designed with something different in mind. It was designed like not opinionated and you get only types what are currently inside data model. Why is that? Because you can save, modify your queries and change everything you want. But a lot of people are not happy with that. So we are going to introduce automating adding and removing queries to reflect changes to the data model.

ianjanicki commented 5 years ago

Great to hear. The fact that you have extended the functionality of the Data Browser is helpful. However you shouldn't take away things users relied on :)

Quick UI feedback: The collapsable query bar is not obvious at all. I think a more elegant approach would be to:

Show query <QueryName> { ... } to show there is a collapsed query
Use syntax highlighting! The admin is very grey 👇

Screenshot 2019-03-18 10 59 18

jwld commented 4 years ago

Was this ever changed back? It still keeps the same queries after deploying. Would be nice to have both auto-generated queries and custom ones.

prisma / prisma-admin-feedback

Types & Queries not updated after deploy #87