search

prisma / prisma-templates

Prisma templates for major cloud providers
MIT License
52 stars 41 forks source link

Remove potentially unused ECSRole from fargate template #37

Open flowirtz opened 5 years ago

flowirtz commented 5 years ago

Call me stupid, but I don't see where the ECSRole is used. 🙈

I think it could be used with the PrismaService (AWS::ECS::Service), as described here, but this states:

If using awsvpc network mode, do not specify this role.

We are indeed using awsvpc network mode.

(Sorry for the Terraform link, I am not using Cloudformation but this should still apply.)

See nathanpeck/aws-cloudformation-fargate#9

PS I'm rewriting the two cloudformation files from the guide in Terraform atm, would you be interested in that or do you not really care?