prisma / prisma1

💾 Database Tools incl. ORM, Migrations and Admin UI (Postgres, MySQL & MongoDB) [deprecated]

https://v1.prisma.io/docs/

Apache License 2.0

16.54k stars 861 forks source link

Chromeos / Crouton / Crosh support #2592

Closed lucasavila00 closed 2 years ago

lucasavila00 commented 6 years ago

Feature Request

What feature are you missing? I'd like to be able to use Prisma services on my Chromebook using crouton via crosh.

How could this feature look like in detail? Tradeoffs? The problem is that when you launch a new browser window and that window can't be opened prisma will exit with code 3. Crosh won't open links but you could do what Create React App does and ignore the fact that the browser hasn't opened and print the url which I can type on the browser. I have run into issues with this using prisma login and prisma playground.

Right now I have to log onto XFCE so that the browser opens when I run playground for instance, then I close XFCE and open the url on chromeos and all is fine.

lucasavila00 commented 6 years ago

They use this implementation to open the browser window: https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/openBrowser.js

I haven't found Prisma's yet but I'm trying to stitch a PR myself. Playground already supports -s option which will only spawn the server, ok.

Error: Exited with code 3
    at ChildProcess.cp.once.code (/home/degroote/teste2/a/node_modules/opn/index.js:84:13)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:925:16)
    at Socket.stream.socket.on (internal/child_process.js:346:11)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at Pipe._handle.close [as _onclose] (net.js:567:12)

lucasavila00 commented 6 years ago

I have submitted PRs for those issues. I guess this can be closed.

Thanks for your awesome work!

marktani commented 6 years ago

Thanks a lot for your contributions @degroote22! We'll review them soon. In the meanwhile, I'll reopen this issue and will close it once those PRs land 💯

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.