Splits Value::Integer into two new variants: Value::Int32 and Value::Int64. SQLite does not honor this contract yet as this would break Prisma, which we want to postpone for Prisma 4. For now, SQLite always returns Int64 as it was already doing before.
⚠️ For better readability, please read ace6d3d instead of the overall PR diff. cargo fmt prevents from having a clear diff, especially on conversion/postgres.rs
⚠️ Also, review the conversions carefully (FromSql & ToSql) as they might lead to unintended breaking changes in Prisma.
Changes
(BREAKING) Value::Integer is removed. Value::Int32 and Value::Int64 replace it.
(BREAKING) PostgreSQL, MySQL and MSSQL returns Value::Int32 and Value::Int64 accordingly now.
(BREAKING) Value::as_i64 only returns the Value::Int64 variant now.
New Value::as_integer() method to be used instead of Value::as_i64 for backward-compatibility.
Overview
⚠️ DO NOT MERGE YET
Splits
Value::Integerinto two new variants:Value::Int32andValue::Int64. SQLite does not honor this contract yet as this would break Prisma, which we want to postpone for Prisma 4. For now, SQLite always returnsInt64as it was already doing before.You'll see a lot of TODOs in the tests which account for SQLite not returning
i32where expected. This work is tracked by https://github.com/prisma/prisma/issues/12784.⚠️ For better readability, please read ace6d3d instead of the overall PR diff.
cargo fmtprevents from having a clear diff, especially on conversion/postgres.rs⚠️ Also, review the conversions carefully (FromSql & ToSql) as they might lead to unintended breaking changes in Prisma.
Changes
Value::Integeris removed.Value::Int32andValue::Int64replace it.Value::Int32andValue::Int64accordingly now.Value::as_i64only returns theValue::Int64variant now.Value::as_integer()method to be used instead ofValue::as_i64for backward-compatibility.