search

prisma / quaint

SQL Query AST and Visitor for Rust
Apache License 2.0
582 stars 61 forks source link

feat(PostgreSQL): support channel_binding query param #424

Closed jannikkeye closed 1 year ago

jannikkeye commented 1 year ago

This PR adds support for the channel_binding query parameter for PostgreSQL.

I've added two tests to check for correct parsing as well as falling back to the default value if none or invalid value is present.

pimeys commented 1 year ago

a small nitpick, otherwise ready to go

pimeys commented 1 year ago

thanks.

jannikkeye commented 1 year ago

@pimeys What does the release flow for changes such as this one look like? Will this be available in the next release of prism and if so when will that release? Thanks in advance.

pimeys commented 1 year ago

It needs testing and documentation. Which is not scheduled for the current sprint. Would you like to do it?

pimeys commented 1 year ago

And quaint should be updated in the engines repo.

jannikkeye commented 1 year ago

It needs testing and documentation. Which is not scheduled for the current sprint. Would you like to do it?

Yeah, sure I’ll add the docs, I think I know where, have added a param before.