Emit query log in quaint:query span, rather than in its parent

prisma / quaint

SQL Query AST and Visitor for Rust

Apache License 2.0

582 stars 62 forks source link

Emit query log in quaint:query span, rather than in its parent #431

Closed miguelff closed 1 year ago

miguelff commented 1 year ago

Tracked in https://github.com/prisma/client-planning/issues/158

Addressed the problem expressed in https://github.com/prisma/client-planning/issues/158#issuecomment-1405530608

Before this change query log events where not attached to the quaint:query span but its parent. This had implications on log capturing. mainly, that BEGIN iTX queries where not logged until its owner span (itx_runner) was not closed at the end of the transaction.

miguelff commented 1 year ago

Given the correct behavior of this patch, the simplicity of the change, and the lack of required reviewers for quaint, I will merge this on Monday, unless there's strong opposition --in a bias to action.