search

prisma / specs

⚠ This repository is not actively used any more, please check out the Prisma Documentation for updated information on Prisma. ⚠
https://docs.prisma.io
87 stars 16 forks source link

Add screenshots to VSCode extension spec #465

Closed carmenberndt closed 4 years ago

carmenberndt commented 4 years ago

Added screenshots showing syntax highlighting, linting, formatting and jump to definition and added the new feature jump-to-definition.

janpio commented 4 years ago

"Linting" doesn't work for me at the rendered version: https://github.com/prisma/specs/blob/updateVSCodeExtensionSpec/vscode-extension/README.md

Can we influence the image size so it shows the font in a similar size than the document itself, and in a consistent size over all images?

janpio commented 4 years ago

(Updated the PR title to be a bit more descriptive)

carmenberndt commented 4 years ago

I uploaded the images to Imgur already, I'll revert that now.

carmenberndt commented 4 years ago

"Linting" doesn't work for me at the rendered version: https://github.com/prisma/specs/blob/updateVSCodeExtensionSpec/vscode-extension/README.md

Are you sure? When I click on the link everything works fine.

Can we influence the image size so it shows the font in a similar size than the document itself, and in a consistent size over all images?

I think so, yes, will do that.

janpio commented 4 years ago

Are you sure? When I click on the link everything works fine.

Yes: image

"Open image in new tab" also shows a 404: https://github.com/prisma/specs/raw/updateVSCodeExtensionSpec/vscode-extension/images/lintingScreenshot.PNG?raw=true

carmenberndt commented 4 years ago

Should be fixed now.