search

prisma / studio

🎙️ The easiest way to explore and manipulate your data in all of your Prisma projects.
https://www.prisma.io/studio
1.81k stars 45 forks source link

Improve loading state for table + tree view #50

Open schickling opened 4 years ago

schickling commented 4 years ago

https://www.loom.com/share/9d35fbd9ea3b45b9a7521d9faae3407b

kuldar commented 4 years ago

Should this be alleviated with triggering the requets for new rows sooner?

Here's few mockups for "placeholder rows" if we should need them though.

table-row-placeholders tree-row-placeholders

schickling commented 4 years ago

Let's do both! 💯

sdnts commented 4 years ago

Will add in skeleton rows too, but with a few perf improvements in alpha.160, white spaces like the one you saw should become pretty rare!

sdnts commented 4 years ago

IMO let's also defer this until after we have a way to know exactly how many records exist in a table. I can then show the correct number of skeleton rows. Thoughts?

schickling commented 4 years ago

IMO let's also defer this until after we have a way to know exactly how many records exist in a table. I can then show the correct number of skeleton rows. Thoughts?

I think there's no harm in filling the screen with skeleton rows even if there are less than displayed while loading. Agree @kuldar?

schickling commented 4 years ago

Will add in skeleton rows too, but with a few perf improvements in alpha.160, white spaces like the one you saw should become pretty rare!

Would be great to implement this soon as it's still very common for the cases I've tried. (I guess related to the fix for #106.)

idan commented 4 years ago

@schickling @madebysid @kuldar is this being worked on? If not, any notion re: priority?

idan commented 4 years ago

tl;dr not sure if to schedule for beta or post-beta

sdnts commented 4 years ago

@idan It isn't, but since yesterday's discussion, I'm planning on picking this (and empty states) up soon. IMO pre-beta, since it isn't a whole lot of work anyway.

matthewmueller commented 4 years ago

We'll do this for the table view.

We'll do it for the tree view if it takes less than 1 hour, otherwise we'll tackle that post-Beta.