create a feature flag for rustls integration

prisma / tiberius

TDS 7.2+ (Microsoft SQL Server) driver for Rust

Apache License 2.0

321 stars 119 forks source link

create a feature flag for rustls integration #212

Closed rogerpengyu closed 2 years ago

rogerpengyu commented 2 years ago

based on the feedback, enable rustls under a feature use_rustls

rogerpengyu commented 2 years ago

waiting for approval to trigger the workflow is painful :(

pimeys commented 2 years ago

Yeah. When this gets merged the next PR will not need an approval. I don't really want to have the actions available for every PR because soon there will be bots triggering bitcoin miners and eating all CI minutes.

rogerpengyu commented 2 years ago

All tests passed. Waiting for approval

rogerpengyu commented 2 years ago

could this be merged? Or any more suggestions?

pimeys commented 2 years ago

I want to do a couple of things here, but merging it for now and doing them in separate PR to get you to the contributors list and you can use the CI more easily after that.

Thank you for the work!