search

prisma / tiberius

TDS 7.2+ (Microsoft SQL Server) driver for Rust
Apache License 2.0
321 stars 118 forks source link

IntoSql impl missing for time crate types #277

Open AlainSchneble opened 1 year ago

AlainSchneble commented 1 year ago

ToSql trait is implemented for time crate types, but IntoSql not:

https://github.com/prisma/tiberius/blob/7d537fa64d6d0dc7a48740c173a898d9d6d7a820/src/tds/time/time.rs#L82

For chrono, both ToSql and IntoSql traits are implemented:

https://github.com/prisma/tiberius/blob/7d537fa64d6d0dc7a48740c173a898d9d6d7a820/src/tds/time/chrono.rs#L151

Is there any reason IntoSql trait impl is missing for time crate types?

The reason I'm asking is because I wanted to use time crate types as parameter in Query::bind method which requires IntoSql. Or am I maybe missing something?

Thanks for tiberius!