search

prisma / tiberius

TDS 7.2+ (Microsoft SQL Server) driver for Rust
Apache License 2.0
311 stars 113 forks source link

fix: allow query on columns with space in name #296

Open Geo-W opened 1 year ago

Geo-W commented 1 year ago

As sql server allows empty space in column name, make it adaptable to columns with space in its name.

tomhoule commented 1 year ago

This looks good. Do you think this would be straightforward to check in a test?

Geo-W commented 1 year ago

This looks good. Do you think this would be straightforward to check in a test?

Sure! Thank you very much~

descawed commented 9 months ago

I was bitten by this issue today when attempting to do a bulk insert to a table having columns with spaces in the name. Is this just waiting on a test to be merged? I can take a crack at it if @Geo-W isn't able to. The code should probably also be updated to handle the case where the column name contains the ] character, which would need to be escaped by doubling it.