search

prisma / tiberius

TDS 7.2+ (Microsoft SQL Server) driver for Rust
Apache License 2.0
311 stars 113 forks source link

Fix todo panic #309

Open wyhaya opened 11 months ago

wyhaya commented 11 months ago

This PR adds an Unimplemented to the Error enum to indicate something that is not implemented, in place of todo! in the code.

todo! causes an error in the programme and it is very difficult to catch it, the reason for submitting this PR is that I did encounter it and I couldn't do anything about it, it would just interrupt the execution of the programme. 

thread 'tokio-runtime-worker' panicked at 'not yet implemented: not yet implemented for Udt', .../src/tds/codec/type_info.rs:317:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I know this is not good practice, but it can serve as a transition period. Until we fix all the todo, then remove it!

Thanks, tiberius

wyhaya commented 8 months ago

It seems that the Tiberius repository is no longer active. Is it possible for this PR to be merged?

janpio commented 8 months ago

Not with failing tests, of course. Get them passing - and we can consider.

wyhaya commented 8 months ago

@janpio I've reviewed the tests, but the test failures are not caused by this PR.

https://github.com/wyhaya/tiberius/actions/runs/7072461970