prismake / typegql

Create GraphQL schema with TypeScript classes.
https://prismake.github.io/typegql/
MIT License
423 stars 21 forks source link

adds prettier #30

Closed capaj closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #30 into master will increase coverage by 0.02%. The diff coverage is 85.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   86.94%   86.97%   +0.02%     
==========================================
  Files          62       62              
  Lines        1088     1090       +2     
  Branches      190      190              
==========================================
+ Hits          946      948       +2     
  Misses        141      141              
  Partials        1        1
Impacted Files Coverage Δ
src/domains/inputField/compiler/fieldType.ts 64.28% <ø> (ø) :arrow_up:
src/domains/objectType/registry.ts 100% <ø> (ø) :arrow_up:
src/services/utils/gql/types/resolve.ts 92.1% <ø> (ø) :arrow_up:
src/domains/field/index.ts 78.26% <0%> (ø) :arrow_up:
src/domains/objectType/compiler/objectType.ts 83.33% <0%> (ø) :arrow_up:
src/domains/index.ts 100% <100%> (ø) :arrow_up:
src/services/utils/getParameterNames.ts 100% <100%> (ø) :arrow_up:
src/domains/inputObjectType/index.ts 76.19% <100%> (+1.19%) :arrow_up:
src/domains/schema/compiler.ts 94.59% <100%> (ø) :arrow_up:
src/domains/schema/rootFields.ts 92.59% <100%> (ø) :arrow_up:
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2f673d...476fd0f. Read the comment docs.

pie6k commented 6 years ago

Thanks!

Could you modify trailingComma to everywhere? It's typescript so it'll get compiled anyway and having it everywhere makes git diffs smaller.

capaj commented 6 years ago

no problem

capaj commented 6 years ago

pushed with those commas now

capaj commented 6 years ago

@pie6k anything still holding this?

pie6k commented 6 years ago

Great! Merged :)