search

prismake / typegql

Create GraphQL schema with TypeScript classes.
https://prismake.github.io/typegql/
MIT License
423 stars 21 forks source link

Falsy values of field dont cause it to be ignored. Only undefined does. #38

Closed pie6k closed 6 years ago

pie6k commented 6 years ago

Fixes #28

Thanks for pointing it! It was silly mistake!

codecov[bot] commented 6 years ago

Codecov Report

Merging #38 into master will increase coverage by 0.07%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   87.04%   87.11%   +0.07%     
==========================================
  Files          62       62              
  Lines        1088     1094       +6     
  Branches      189      190       +1     
==========================================
+ Hits          947      953       +6     
  Misses        140      140              
  Partials        1        1
Impacted Files Coverage Δ
src/domains/field/compiler/resolver.ts 91.66% <88.88%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a342e45...c6f05ad. Read the comment docs.