Improved docker compose for tests

prismamedia / metrics

Symfony bundle to expose your own metrics to Prometheus

BSD 3-Clause "New" or "Revised" License

15 stars 5 forks source link

Improved docker compose for tests #21

Closed nightio closed 4 months ago

GromNaN commented 4 months ago

How does it improve? I can see config becoming more complicated, but I'm not sure there's much point in improving test performance on such a small library.

nightio commented 4 months ago

I just spent 10 minutes to review my previous approach and change it. It the changed version, docker will not touch local files anymore which is better for development. It uses anonymous volumes and container file system for any modified files.

However, you can close the PR if you wish. I made it for fun 🙂

GromNaN commented 4 months ago

Okay, have it your way. While you are at it, you could exclude docker files in .gitattributes. Thank you.

nightio commented 4 months ago

Done. I also changed phpunit.xml to phpunit.xml.dist in .gitattributes