prismicio-community / eleventy-plugin-prismic

Eleventy plugin and shortcodes to fetch and present Prismic content
https://github.com/prismicio-community/eleventy-plugin-prismic/blob/master/DOCUMENTATION.md
MIT License
98 stars 5 forks source link

support for Prismic Client 6.0.0-beta.3 #5

Closed kingbiscit closed 3 years ago

kingbiscit commented 3 years ago

refactor!: support for Prismic Client 6.0.0-beta.3

BREAKING CHANGE: refactor to use client.dangerouslyGetAll() instead of client.getAll()

Types of changes

Description

Prismic Client 6.0.0-beta.3 breaks this plugin by renaming client.getAll() to client.dangerouslyGetAll().

This change updates the call and test to use client.dangerouslyGetAll() and sets @prismicio/client to use ^6.0.0-beta.3.

This resolves this issue:

Checklist:

lihbr commented 3 years ago

God I'm sorry 🙏 Went ahead at the same time as you and did the fix, now available in 0.1.3

Thank you so much for your willing to contribute though!

P.S. Just a FYI but I don't consider that as a breaking change as it just impacts the internals of the plugin, not the user-exposed API ☺️

kingbiscit commented 3 years ago

No problem at all. I am just learning how best to contribute so hopefully I can add a few more things.

I have been working with Prismic for over 5 years but always using PHP, this plugin and 11ty is amazing!

lihbr commented 3 years ago

You're more than welcome to do so! What you did with the issue and the PR was perfect 💯

And glad to hear that! Feel free to open issues to suggest things or such if you have ideas! It's still on my TODO to make the plugin support Prismic previews, hopefully there's a way to do so with 11ty serverless~