search

prismicio-community / nuxt-starter-prismic-blog

Blog project with Nuxt & Prismic
https://nuxt-starter-prismic-blog.vercel.app
Apache License 2.0
55 stars 32 forks source link

feat: refresh code and use Slice Machine #26

Closed angeloashmore closed 2 years ago

angeloashmore commented 2 years ago

This PR contains a rewrite of the blog example based on nextjs-sample-blog.

It contains the following major changes:

  1. Uses Slice Machine
  2. Uses Tailwind CSS
lihbr commented 2 years ago

Awesome, was very great! Made some minor edits that you can see in 44c307f

Regarding Slice Simulator, apparently libraries-state.json was out of sync, I recreated it in 3659f39 Now it works, but that's very odd 🤔 Do you think it's a bug it didn't work for you?

Everything is available in #27 as I don't have push access to this repository and Mehdi wasn't available today :/

angeloashmore commented 2 years ago

Thanks for the review!

I migrated the Slice models from the Next.js project by copy/pasting the model.json files. I guess I needed to edit a field or something for libraries-state.json to regenerate. I can't fault Slice Machine for not regenerating state since I didn't trigger it with an action. I guess Slice Machine could refresh state when pushing to Prismic, but I'm not sure that's really the best design.

I merged your changes and will follow your conventions for the next starter. Thanks!