search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
108 stars 82 forks source link

Update egeloen/http-adapter to 0.8.0. Updated code for API changes in egeloen/http-adapter. All tests pass. #113

Closed freefoote closed 8 years ago

freefoote commented 9 years ago

Related to issue #111.

I've got a Symfony 2.7 project and I was unable to install the php-kit due to a conflict with Guzzle. egeloen/http-adapter 0.8.0 doesn't conflict, but the API is slightly different and then caused the PHP kit to stop working.

This pull request updates the library to 0.8.0 and fixes the internal parts of the Prismic API class that stopped working as a result. From what I can see it shouldn't affect code using the Prismic API classes, but those who've worked on this code for a while might be able to shed more light on this.

All the unit tests pass with my changes.

freefoote commented 9 years ago

Ah, that's right, I read somewhere that it was intended to retain PHP5.3 compatibility. In the interim I'll use my fork for my project. I'll leave this open in case anyone else has other ideas on how to make this work and meet the Prismic PHP kit's goals.

rap2hpoutre commented 8 years ago

PHP 5.3 end of life was on 14 Aug 2014. (and 5.4 on 14 Sep 2015) More info here: https://secure.php.net/supported-versions.php You should drop this version support in a v2.0.0 of prismic.io (if you don't want to break compatibility with old projects running on 5.3 at their own risk).

rap2hpoutre commented 8 years ago

So in other words, you could accept and merge this PR and create an backward incompatible release.

Anyway https://github.com/egeloen/ivory-http-adapter seems deprecated too. :'(

erwan commented 8 years ago

@rap2hpoutre the library proposed to replace egeloen/ivory-http-adapter doesn't seem to be ready yet (incomplete, no doc) so let's stick with ivory-http-adapter until the replacement matures a bit.

rap2hpoutre commented 8 years ago

Ok, thanks!