search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
108 stars 82 forks source link

Symfony 3.2 compatibility #128

Closed CHH closed 7 years ago

CHH commented 7 years ago

Hi, the version constraint on the symfony/event-dispatcher component isn't working with Symfony 3.2.

Here's the composer output:

composer require prismic/php-sdk
Using version ^3.1 for prismic/php-sdk
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for prismic/php-sdk ^3.1 -> satisfiable by prismic/php-sdk[3.1.0].
    - Conclusion: remove symfony/symfony v3.2.1
    - Conclusion: don't install symfony/symfony v3.2.1
    - prismic/php-sdk 3.1.0 requires symfony/event-dispatcher ~3.1.4 -> satisfiable by symfony/event-dispatcher[v3.1.4, v3.1.5, v3.1.6, v3.1.7, v3.1.8].
    - don't install symfony/event-dispatcher v3.1.4|don't install symfony/symfony v3.2.1
    - don't install symfony/event-dispatcher v3.1.5|don't install symfony/symfony v3.2.1
    - don't install symfony/event-dispatcher v3.1.6|don't install symfony/symfony v3.2.1
    - don't install symfony/event-dispatcher v3.1.7|don't install symfony/symfony v3.2.1
    - don't install symfony/event-dispatcher v3.1.8|don't install symfony/symfony v3.2.1
    - Installation request for symfony/symfony (locked at v3.2.1) -> satisfiable by symfony/symfony[v3.2.1].

Installation failed, reverting ./composer.json to its original content.

Is there anything that has to require the 3.1 version of the component? Could I submit a PR that changes it to a ^3.1 constraint? Symfony probably won't break anything until 4.x, see here: http://symfony.com/doc/current/contributing/code/bc.html