prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
109 stars 83 forks source link

PHP >=7.1 #150

Closed gsteel closed 6 years ago

gsteel commented 6 years ago

This pull is WIP for comment/review. It's purpose is to clean up the library and use scalar type hints where possible and update deps etc. I also plan to…

debiasio commented 6 years ago

Thanks again for you initiative.

For now, we want to first make some updates to the php-kit, including the Psr\Cache, but to keep the actual PHP versions support.

And after, we plan to make the new version of the php-kit that makes the move to PHP >= 7.1. Aim is to publish this version in November.

gsteel commented 6 years ago

So why was the v2 branch merged into master? These are massive breaking changes so why not just crack on with all the other BC breaks? How are you going to release fixes and updates for customers using v1 api in 3.x between now and November?

debiasio commented 6 years ago

Ok, so, let's publish all the breaking changes in one go, for php-kit v4. Let's make small PRs for each update:

We are now examining this PR.

gsteel commented 6 years ago

OK, I'll leave out Psr\Cache for now, but it make more sense to me to test at the same time, that way you're only merging code that theoretically does what it's supposed to do??

debiasio commented 6 years ago

Yes yes, add tests according to this PR. Thanks

gsteel commented 6 years ago

@jbdebiasio How's this looking to you?

gsteel commented 6 years ago

@jbdebiasio, @srenault - Any chance of review?

arnaudlewis commented 6 years ago

Other than my few questions, seems great. We'll go through it during the call with @jbdebiasio