PHP >= 7.1 v4 Candidate

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language

https://prismic.io

Other

108 stars 82 forks source link

PHP >= 7.1 v4 Candidate #158

Closed gsteel closed 4 years ago

gsteel commented 6 years ago

This is a very large PR from a fork I've been maintaining. There would need to be some cleanup, specifically the README and composer stuff. There's not a huge amount of BC breaks compared with v3 and it maintains compat with API v1 AFAICT. It's based on PR #150 and comes with a number of useful features.

Highlights:

PSR-6/PSR-16 cache
Hydrate documents to your own models to easily encapsulate logic
Test coverage > 95%
Predictable namespaced exceptions throughout

There's a bit more info here: https://github.com/netglue/prismic-php-kit/releases/tag/4.0.0

This should fix #157, #152 and #117 also maybe #155

damyanovg commented 6 years ago

Hello I am wondering if this PR is going to be merged soon?

OwenMelbz commented 5 years ago

@gsteel what ever happened with this?

gsteel commented 5 years ago

This did…

OwenMelbz commented 5 years ago

Oh lovely :D feels like this product has been abandoned!

gsteel commented 5 years ago

The product is very much alive and well - I'm still using it all the time. There's just no love for PHPers. I maintain my own fork for my own specific needs - it's quite opinionated but contributions are welcome :)

OwenMelbz commented 5 years ago

Ah sorry, when i said "this product" I meant - this facet of the product, e.g. the PHP SDK.

It's a shame as looks great in so many ways until you try and use it with PHP then is less polished as everything else

gsteel commented 5 years ago

FWIW, I'm really happy using the fork. I do my best to follow semver and keep things stable. Kick the tyres or fork away ;) Coverage is pretty good