search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
109 stars 83 forks source link

Boolean fix #166

Closed mjolk closed 2 years ago

mjolk commented 4 years ago

querying boolean fields fails. Php boolean translates to 0/1 -> error. String adds escape -> fails

mjolk commented 4 years ago

php 7.4 btw php is not my normal haunt so for tests etc i lack the time and inclination

sleicester commented 4 years ago

We're experiencing the same issue as well, I've created another PR that includes tests around this.

proclame commented 3 years ago

This PR is a duplicate of #167 which has now been merged in. Seems safe to close.

c0nst4ntin commented 2 years ago

Seems to me as if @proclame is right. I will close this PR