search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
108 stars 82 forks source link

Serialize boolean values #167

Closed sleicester closed 3 years ago

sleicester commented 4 years ago

Since the last tagged release (5.1.1) the boolean field has been released.

We've made good use of this and have come across an issue where this field is not serialised properly, passing through 1 and 0 instead of true and false.

I've added a simple test around this.

proclame commented 3 years ago

Hey @sleicester,

Thank you for creating this PR. just ran into the same problem, and got to the exact same fix, and wanted to create a PR. Unfortunately, looks like Prismic is not actively maintaining this repo anymore?

@prismicio, @Raph22 Do you have any intentions of pulling this in & tagging? Would be very helpful. Anything else you need for this to go through?

Thank you!

sleicester commented 3 years ago

Hi @proclame,

Yes indeed, not much has been happening here but I've started chasing via the chat within Prismic, and would encourage you to do the same if possible.

srenault commented 3 years ago

Thanks for the PR