search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
109 stars 83 forks source link

Bug fixes and additions #3

Closed remidewitte closed 11 years ago

remidewitte commented 11 years ago

I have begun to implement the Les Bonnes Choses show case in CakePHP. I took the scala one and tried to convert the code quite as straightforward as I can. I did have few issues with the kit. Here are my fixes and additions.

srenault commented 11 years ago

Thanks for you contributions ! Recently, we make a huge refactoring to make the PHP code more standard. To merge your PR, I have two choices: 1) Merge by hand you PR. We will loose that it's you behind the commit. 2) You can update your PR.

What do you prefer ?

remidewitte commented 11 years ago

You may go ahead with option 1). I'll be a happy tester of the new refactored kit !

rande commented 11 years ago

it will be great if you can add unit tests for any changes ... so this will make the code more stable.

@srenault did you add the project to travis ?

srenault commented 11 years ago

I'm currently working on adding some bunch of tests. After that, I will add travis.