search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
109 stars 83 forks source link

Heading blocks and first heading can be fetched from StructuredText. #55

Closed robinvdvleuten closed 10 years ago

robinvdvleuten commented 10 years ago

In addition to my previous PR, now you can also fetch all HeadingBlock types from a StructuredText instance.

rudyrigot commented 10 years ago

It seems like this fails for PHP 5.4 and PHP 5.3. I don't see anything that might trigger this failure, do you want to look into it?

rudyrigot commented 10 years ago

Never mind, the failure is in one of the recent commits that were made to master, that you branched from. I'll fix it there first, and will look into your PR afterwards. Sorry about that.

robinvdvleuten commented 10 years ago

Yeah it looks like there are some serializing/apc issues in the master branch.

rudyrigot commented 10 years ago

Merged!

The only thing that was probably missing here was a bit of documentation. I know the documentation in the kit hasn't been that great, but I'm revamping it entirely, and I'm almost done entirely with it (maybe even today!). I see StructuredText is one of the classes I haven't deal with yet, so I'll document these new methods along with the other methods in StructuredText, no worries.

Thanks for the PR!

robinvdvleuten commented 10 years ago

Cool! I'll keep the documentation in mind for a next PR.