prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
108 stars 82 forks source link

Made the client instance overridable. #61

Closed robinvdvleuten closed 10 years ago

robinvdvleuten commented 10 years ago

I have made the client overridable so users can inject their own Guzzle instance. They also can access the current client instance with the getClient() method. I saw in the code that you've made some sort of base for the functionality and I build this PR on top of it.

The main reason this functionality is important for me is to have some sort of mocking functionality in the (coming soon) SymfonyBundle tests.

rudyrigot commented 10 years ago

Merged! Thanks for the PR.

(Note: the build was failing because of IDs that changed in the test repository, not because of the changes in the code).

robinvdvleuten commented 10 years ago

I already saw it locally when running the tests that some strings weren't matching.