prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
109 stars 83 forks source link

Redis cache #67

Closed webguyblake closed 10 years ago

webguyblake commented 10 years ago

I thought being able to use Redis as a cache would be a good enhancement. In the current project I'm working on we use Redis as a stack and as a data cache and thought it would fit nicely as a cache for prismicio data.

erwan commented 10 years ago

Hi,

Thank you for your contribution! That's great to see a Redis implementation for the Cache.

However, we'd rather keep specific cache implementations out of the kit to avoid increasing the maintenance cost. We included the "naive" cache implementation precisely so you can look at it as an exemple an implement support for Redis or other products like Memcached, CouchDB, Riak...

You should be able to use your Redis class without modifying the kit itself - I propose you to share this class as a separate github repository or even just a Gist since it is a single file.