search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
108 stars 82 forks source link

Support label spans within Structured Text fragments #68

Closed gsteel closed 9 years ago

gsteel commented 9 years ago

Enables label spans within Structured Text fragments so content is marked up ...<span class="my-label">My Labelled Text</span>...

Sorry I've not added tests - not sure how to go about adding tests given that I'd need repo access???

erwan commented 9 years ago

Hi,

Thank you for the pull request!

For tests, the best is to use a fixture, so you don't need to change the repo (and the test won't break if there is a change in the repo): https://github.com/prismicio/php-kit/blob/master/tests/fixtures/search.json https://github.com/prismicio/php-kit/blob/master/tests/Prismic/StructuredTextTest.php#L15