search

prismicio-community / php-kit

Community maintained development kit for Prismic and the PHP language
https://prismic.io
Other
108 stars 82 forks source link

Scheduled ref timestamps #71

Closed gsteel closed 9 years ago

gsteel commented 9 years ago

Perhaps this might break BC as getScheduledAt() is returning something different, but, in PHP do you think it's fair to say that you'd expect a Unix timestamp rather than a JS timestamp anyway?

erwan commented 9 years ago

Hi,

Thank you for the PR!

I agree with your getScheduledDate method that we should use a DateTime, that removes the seconds/milliseconds confusion.

However since maybeScheduledAt is for internal use anyway, I'd rather keep it the way we received it from Prismic and do the / 1000 in the getScheduledDate method.

Also, that's not mandatory but could you rebase and squash your commits to get a cleaner history?

gsteel commented 9 years ago

Sorry, I tried squashing the commits and screwed it up...

erwan commented 9 years ago

No problem, squashing is preferred but we can do without.