search

prismicio-community / storybook-addon-gatsby

Storybook addon used to load stories built with Gatsby
Apache License 2.0
7 stars 6 forks source link

babel-plugin-remove-graphql-queries not defined as a dependency #2

Open njbmartin opened 2 years ago

njbmartin commented 2 years ago

https://github.com/prismicio-community/storybook-addon-gatsby/blob/8d0819a7db145fec124377420c977c0aea1eec49/src/index.ts#L49

Following the instructions from: https://www.gatsbyjs.com/docs/how-to/testing/visual-testing-with-storybook/

But it's also not documented here.

Either suggest:

npm i --save-dev  storybook-addon-gatsby babel-plugin-remove-graphql-queries

or add it as a dependency.

angeloashmore commented 2 years ago

Hi @njbmartin, babel-plugin-remove-graphql-queries should already be installed as it is a dependency of Gatsby.

When you use the addon, do you get an error saying babel-plugin-remove-graphql-queries is not installed?

njbmartin commented 2 years ago

I did yes, new Gatsby V4 starter

On Fri, 8 Oct 2021 at 21:18, Angelo Ashmore @.***> wrote:

Hi @njbmartin https://github.com/njbmartin, babel-plugin-remove-graphql-queries should already be installed as it is a dependency of Gatsby.

When you use the addon, do you get an error saying babel-plugin-remove-graphql-queries is not installed?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/prismicio-community/storybook-addon-gatsby/issues/2#issuecomment-939093176, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLPPD6RNKLINLXBOLITNODUF5GXTANCNFSM5FTLTZOA .

angeloashmore commented 2 years ago

@njbmartin Which starter did you use? I can test it on my side to see how we should address this. Thanks!