search

prismicio / SymfonyBundle

Inntegrates the http://prismic.io php-kit with the Symfony Framework
http://prismic.io
8 stars 11 forks source link

Freezing the prismic.io PHP kit to a given version #8

Closed rudyrigot closed 10 years ago

rudyrigot commented 10 years ago

I'm not a Symfonist, so bear with me.

A user on support has reported that a composer update broke his Symfony application. Indeed, we introduced some breaking changes in the PHP kit recently, which is likely to happen once in a while, and some of them may require changes in the Symfony Bundle. It seems that the version of the PHP kit is not frozen in the Symfony Bundle, and the master branch is pulled now, so it really should be frozen.

The 1.0.4-dev version of the kit is at the same time recent and stable; I believe it works with the Symfony Bundle, but I wouldn't really know how to check. Can someone freeze the version of the PHP kit to that version (hopefully, that's what I'm doing in that PR), and check that everything is alright, before someone else runs a deadly composer update?

Thanks a lot!

robinvdvleuten commented 10 years ago

This won't work as fixed version because you have replaced dev-master with an alias of dev-master (1.0.4.x-dev, see here. When any new commits are added to master, they will be added to your alias as well. A better option would be to fix the version by adding a composer.lock file to the repository.

robinvdvleuten commented 10 years ago

I can send in a new PR with a composer.lock if you like

rudyrigot commented 10 years ago

Yes, that would be very, very helpful; thank you so much!