search

prismicio / prismic-dom

Set of helpers to manage Prismic data
https://prismic.io/docs/technologies/prismic-dom-technical-reference
44 stars 16 forks source link

Update prismic-richtext to reduce bundle size #36

Closed controversial closed 4 years ago

controversial commented 4 years ago

Closes #35

hypervillain commented 4 years ago

Thank you for this! I believe it's also time to bump the node versions that Travis checks for. Could update the travis.yml file?

Values to handle are probably 8, 10 and 12.

thanks!

controversial commented 4 years ago

@hypervillain I updated the node versions in .travis.yml to the ones you specified. Webpack v2 doesn't support node versions after 9.x, so I also updated the package.json and webpack.config.js to webpack v4, but that update should definitely get a second pair of eyes.

It look like the tests are still failing because of broken test cases—there are some test cases that expect <em><strong></strong</em> while prismic-dom is generating the equivalent <strong><em></em></strong> (order is reversed). Let me know how we should proceed.

hypervillain commented 4 years ago

@controversial The tests were indeed failing on non v12 node versions. Because they're actually quite old and not really relevant, I thought the best choice was to actually remove them from the codebase. I juste merged your code with the deletion.

I don't have the rights to publish unfortunately. @arnaudlewis can you do it asap?

simonmaass commented 4 years ago

can this please be released... please...