search

prismicio / prismic-react

React components and hooks to fetch and present Prismic content
https://prismic.io/docs/technologies/homepage-reactjs
Apache License 2.0
154 stars 40 forks source link

Change React to a dev and peer dependency #11

Closed alfredringstad closed 5 years ago

alfredringstad commented 6 years ago

Since this package doesn't bundle React, that shouldn't be a dependency, but a peerDependency (and devDependency used for testing).

With the current setup (having React 15.6.1 as a dependency) you get two different React versions if the app you're using prismic-reactjs in is using React 16, which messes things up really bad.

This commit removes React as a dependency and adds it as a peerDependency and devDependency, thus solving this problem.

alfredringstad commented 5 years ago

@levimykel Is there any plans to merge this or other ways to support React 16?

baires commented 5 years ago

Any updates or intentions to merge this branch?

arnaudlewis commented 5 years ago

Sorry for the delay, we're gonna take a look in the next couple days.