prismicio / prismic-react

React components and hooks to fetch and present Prismic content

https://prismic.io/docs/technologies/homepage-reactjs

Apache License 2.0

153 stars 40 forks source link

fix: type context, components in SliceZoneProps #159

Closed Vorseek closed 1 year ago

Vorseek commented 1 year ago

Types of changes

[ ] Chore (a non-breaking change which is related to package maintenance)
[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix types context in components props, for SliceZone

Checklist:

[ ] My change requires an update to the official documentation.
[x] All TSDoc comments are up-to-date and new ones have been added where necessary.
[x] All new and existing tests are passing.

cat

codecov-commenter commented 1 year ago

Codecov Report

Merging #159 (71fecf6) into master (b630f12) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          18       18           
  Lines         334      334           
  Branches       84       84           
=======================================
  Hits          306      306           
  Misses          5        5           
  Partials       23       23

Impacted Files	Coverage Δ
src/SliceZone.tsx	`84.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b630f12...71fecf6. Read the comment docs.

angeloashmore commented 1 year ago

Thanks for the fix, @Vorseek! 😸

This will be published in the next release.

dturkington49 commented 1 year ago

Currently blocked by this issue. Is a release possible in the coming days?

angeloashmore commented 1 year ago

Hi @dturkington49, thanks for the reminder. I was waiting to bundle this fix with other changes, but we haven't had to fix anything since this bug.

I just published it as v2.4.3. You should be able to update to the latest version with the following command:

npm install @prismicio/react@latest

If that doesn't fix your issue, please let me know by opening a new issue or commenting here. Thanks! 🙂

dturkington49 commented 1 year ago

@angeloashmore Wow, thanks for the quick response! Upgraded to 2.4.3 and I'm unblocked. Thank you!