search

prismicio / prismic-react

React components and hooks to fetch and present Prismic content
https://prismic.io/docs/technologies/homepage-reactjs
Apache License 2.0
154 stars 40 forks source link

Recent update not working in Internet Explorer #24

Closed edahlseng closed 4 years ago

edahlseng commented 4 years ago

After the recent update to v1.0.0, it appears that this module is failing in Internet Explorer. I'm still not sure why or what the final fix would be. Has anyone else seen this?

sambou commented 4 years ago

Yup, same here. The issue seems to be in prismic-richtext, this is what I'm getting on the console:

SyntaxError: Expected identifier, string or number at ./node_modules/prismic-richtext/dist/prismic-richtext.min.js
hypervillain commented 4 years ago

mmh, that's weird. I actually did a PR on prismic-richtext that was supposed to get rid of that kind of issues. See here: https://github.com/prismicio/prismic-richtext/commit/ab1228f89bc714b93c7515ac1072dd18e672e9ae#diff-11e9f7f953edc64ba14b0cc350ae7b9d

I may take some time to investigate next week but any help would be greatly appreciated

hypervillain commented 4 years ago

Hey guys,

try updating the package to 1.0.1 and you should be good to go!

edahlseng commented 4 years ago

Thanks @hypervillain! We'll give it a shot next week!

hypervillain commented 4 years ago

Perfect, I'll close the issue. Tell me how it goes!

craigtaub commented 4 years ago

The update fixed it for us.