search

prismicio / prismic-react

React components and hooks to fetch and present Prismic content
https://prismic.io/docs/technologies/homepage-reactjs
Apache License 2.0
154 stars 40 forks source link

Typings missing from NPM publish #52

Closed ryan-codingintrigue closed 2 years ago

ryan-codingintrigue commented 4 years ago

The typings folder appears to be missing from the published NPM package:

https://unpkg.com/browse/prismic-reactjs@1.3.0/

Not sure if this is intentional or not, given that it's in the package.json seems like this might me a mistake...

cyrilchapon commented 4 years ago

It's manually .npmignored here; thus making the package.json typings field unworking.

ohlr commented 4 years ago

https://github.com/prismicio/prismic-reactjs/commit/ff8a1c5a8e798a2b4e69024a1e79dc20fe2841bd @cyrilchapon when will this be released?

cyrilchapon commented 4 years ago

I have no clue my friend; just quickly PRed this to get this done.

cyrilchapon commented 4 years ago

@ohlr ; hum; it's live actually.

ohlr commented 4 years ago

ah sorry I only looked at the releases here on github which are not actively maintained

codingwithchris commented 3 years ago

Any update on this? I am seeing the typings/index.d.ts file in the actual node modules package but my project still isn't recognizing it:

Could not find a declaration file for module 'prismic-reactjs'

On v1.3.1.

Also, FWIW, upon inspection of the file, Typescript is complaining about a lot of errors. I'm getting no less than 23 errors.

Examples: Screen Shot 2020-07-05 at 2 45 02 PM

codingwithchris commented 3 years ago

Ahh... seeing now that this is directly related to #62 and #61.

angeloashmore commented 2 years ago

Hey everyone, I know this is an old issue, but here's a quick update.

@prismicio/react v2 was just published and is now written completely in TypeScript. Going forward, all types will be maintained alongside the source code and in @prismicio/types.

Thanks for your feedback!