Closed angeloashmore closed 1 year ago
Merging #51 (6c0eda4) into main (e237257) will decrease coverage by
1.67%
. The diff coverage is97.01%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 98.73% 97.07% -1.67%
==========================================
Files 23 20 -3
Lines 1655 1468 -187
Branches 142 160 +18
==========================================
- Hits 1634 1425 -209
- Misses 21 42 +21
- Partials 0 1 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/lib/getHumanReadableModelName.ts | 82.22% <78.26%> (-5.88%) |
:arrow_down: |
src/lib/getHumanReadablePath.ts | 87.50% <87.50%> (ø) |
|
src/lib/buildSharedSliceType.ts | 93.42% <93.42%> (ø) |
|
src/lib/buildFieldProperties.ts | 97.07% <97.07%> (ø) |
|
src/lib/buildFieldDocs.ts | 98.51% <98.43%> (-1.49%) |
:arrow_down: |
src/constants.ts | 100.00% <100.00%> (ø) |
|
src/generateTypes.ts | 100.00% <100.00%> (ø) |
|
src/lib/addBlankLine.ts | 100.00% <100.00%> (ø) |
|
src/lib/addLine.ts | 100.00% <100.00%> (ø) |
|
src/lib/addSection.ts | 100.00% <100.00%> (ø) |
|
... and 8 more |
Types of changes
Description
This PR reimplements type generation using string concatenation. It replaces the current TypeScript Compiler API +
ts-morph
solution.Initial benchmarking shows ~1000x improvement in projects with 10 custom type and 10 Slices. With caching enabled, which is only persisted in memory and used in subsequent generations, we see a ~4600x improvement. Additional testing will be performed on larger projects.
Run the benchmark using:
Related issues
Checklist:
🐆